[RHOAIENG-10318] Add connection type field modal #3082
Merged
+420
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@simrandhaliw What are the restictions on the |
jeff-phillips-18
force-pushed
the
connection-type-add-field
branch
from
07fcc3a to
93223f0
Compare
jeff-phillips-18
changed the title
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
jeff-phillips-18
force-pushed
the
connection-type-add-field
branch
from
93223f0 to
90951a8
Compare
jeff-phillips-18
force-pushed
the
connection-type-add-field
branch
5 times, most recently
from
a360163 to
99cada4
Compare
jeff-phillips-18
force-pushed
the
connection-type-add-field
branch
from
99cada4 to
9e97d43
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: christianvogt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes RHOAIENG-10318
Description
Adds a modal to allow adding of a field to a connection type
Screen shots
How Has This Been Tested?
Added unit tests
Test Impact
Add tests for adding/editing/duplicating fields in a connection type.
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
/cc @simrandhaliw